Fixed [Environment] OpenCV NULL guiReceiver error during pre-commit #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esting . added a check to see if a window is available, or create one if its not.
Udayraj123
reviewed
Oct 11, 2024
| @@ -38,6 +38,9 @@ def show(name, origin, pause=1, resize=False, reset_pos=None, config=None): | |||
| else: | |||
| img = origin | |||
|
|
|||
| if not is_window_available(name): | |||
| cv2.namedWindow(name) | |||
There was a problem hiding this comment.
can you add this for the cv2.moveWindow() as well?
There was a problem hiding this comment.
@Udayraj123 Its not needed separately for the same, We can do that but it does not affect anything as we are already handling the case when we don't have window here, so no need to do it again.
|
Thanks, added a comment @Princekumarofficial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#230
Fixed [Environment] OpenCV NULL guiReceiver error during pre-commit testing .
Added a check to see if a window is available, or create one if its not.