Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 7561/emotion memoize all generated styles eui tool tip+euicon tip #7561 #3

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

SamuelSanchez01
Copy link
Collaborator

@SamuelSanchez01 SamuelSanchez01 commented Dec 13, 2024

Summary

This PR provides:

  • Memoization of generated styles with useEuiMemoizedStyles from src/services

This PR doesn't contain:

  • Changes in UI

QA

We verify that all the JEST run

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

Copy link

👋 Since this is a community submitted pull request, a Buildkite build has not been started automatically. Would an Elastic organization member please verify the contents of this pull request and kick off a build manually?

@SamuelSanchez01 SamuelSanchez01 changed the title Issue 7561/emotion memoize all generated styles eui tool tip+euicon tip Issue 7561/emotion memoize all generated styles eui tool tip+euicon tip #7561 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants