Skip to content

bugfixed incorrect files created + store output#5

Merged
fdekievit merged 3 commits into
developfrom
feature/default-fix-output-fix
Jul 7, 2026
Merged

bugfixed incorrect files created + store output#5
fdekievit merged 3 commits into
developfrom
feature/default-fix-output-fix

Conversation

@fdekievit

Copy link
Copy Markdown
Collaborator

Added bugfix 1:

when running with --max_distance 2 it should now correctly calculate files hamming_distance_1.txt, hamming_distance_2.txt and hamming_distance_0.txt (and not skip the last one).

Added feature output path:

An outpath can now be given to write the hamming_distance_x.txt calculations to a specific path

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
src/hammingdistancecalculator
   __init__.py00100% 
   hamming_distance.py102694%27, 45, 110, 124, 126, 261
TOTAL102694% 

Tests Skipped Failures Errors Time
51 0 💤 0 ❌ 0 🔥 0.707s ⏱️

@BasMonkey BasMonkey left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting check fails. Could you please fix that?

Comment thread .gitignore Outdated
Comment thread pyproject.toml
Comment thread tests/test_hamming_distance.py
@BasMonkey BasMonkey self-requested a review July 7, 2026 08:27

@BasMonkey BasMonkey left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@fdekievit fdekievit merged commit fc8f95f into develop Jul 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants