Skip to content

Conversation

@Aprillion
Copy link
Contributor

This PR contains:

  • New features
  • Changes to dev-tools e.g. CI config / github tooling
  • Docs
  • Bug fixes
  • Code refactor

What is the current behavior? (You can also link to an open issue here)

  • Inspect View: on Tasks tab, when inside a folder that is an eval set that is still running, we hide retried logs and only show the latest, but if the eval set is already finished we display all log files

What is the new behavior?

  • hide retried logs by default, add a button to Show Retried Logs to be able to see them regardless of eval set running status

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • no

Other information:

Copy link
Collaborator

@dragonstyle dragonstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment -looks good!

const currentDirTaskIds = new Set(
currentDirLogFilesMaybeSkippedRetries.map((f) => f.task_id),
);
let count = currentDirLogFilesMaybeSkippedRetries.length;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bottom-right corner count will now match the Tasks panel (number of deduplicated log files) instead of different counts between the 2 panels

Copy link
Collaborator

@dragonstyle dragonstyle Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying the footer will now display the number of log files that match vs the number of samples (when in the sample view)? If so, that seems wrong to me - that lower right corner number is intended to display the total number of items being displayed in the grid control (given filtering, etc...).

Copy link
Contributor Author

@Aprillion Aprillion Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I didn't change that part, but LogListFooter displays different info in different situations that I was not aware of:

  • if eval set is already finished, it's already showing number of samples (same on main branch and this PR ... but my PR needs a fix to reflect Show Retried Logs)
    • fix sample count in lower right corner
  • if eval set is still running (totalTaskCount !== completedTaskCount), it toggles to show progress bar (same on main branch and this PR ... but the count in this PR was already reflecting Show Retried Logs when I wrote my comment => hopefully no further fixes needed)

@Aprillion Aprillion requested a review from dragonstyle January 8, 2026 10:08
Copy link
Collaborator

@dragonstyle dragonstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all this work - this is a tricky problem to get right! I've made some suggestions.

@Aprillion Aprillion requested a review from dragonstyle January 8, 2026 19:56
@dragonstyle dragonstyle merged commit c653230 into UKGovernmentBEIS:main Jan 8, 2026
14 checks passed
@dragonstyle dragonstyle deleted the feature/show-retried-logs branch January 8, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants