Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devise-two-factor 5.x upgrade phase 2 #2519

Merged
merged 1 commit into from
Feb 4, 2025
Merged

devise-two-factor 5.x upgrade phase 2 #2519

merged 1 commit into from
Feb 4, 2025

Conversation

rgarner
Copy link
Contributor

@rgarner rgarner commented Feb 4, 2025

Clean up legacy columns and legacy OTP accessor method

Changes in this PR

Screenshots of UI changes

Before

After

Next steps

  • Is an ADR required? An ADR should be added if this PR introduces a change to the architecture.
  • Is a changelog entry required? An entry should always be made in CHANGELOG.md, unless this PR is a small tweak which has no impact outside the development team.
  • Do any environment variables need amending or adding?
  • Have any changes to the XML been checked with the IATI validator? See XML Validation

benshimmin
benshimmin approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@benshimmin benshimmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎸

@rgarner
devise-two-factor 5.x upgrade phase 2
bdde125 
Clean up legacy columns and legacy OTP accessor method
@rgarner rgarner force-pushed the devise-2fa-5x-cleanup branch from 2ac7e77 to bdde125 Compare February 4, 2025 12:09
@rgarner
Copy link
Contributor Author

rgarner commented Feb 4, 2025 •
edited
Loading

@benshimmin I'd forgotten to remove otp_secret_encryption_key from User. Done now.

@rgarner rgarner merged commit 7f5baa4 into develop Feb 4, 2025
3 checks passed
@rgarner rgarner deleted the devise-2fa-5x-cleanup branch February 4, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benshimmin benshimmin benshimmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgarner @benshimmin