Refactor DownloadLinkMailer #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we attempted to update to a new version of Ruby, this Mailer stopped working. We are not sure why, but switching to positional arguments resolves the issue, UserMailer uses positional arguments so we assume that this is acceptable. Making this refactor opens the door to update Ruby.
mec
force-pushed
the
refactor/download-link-mailer
branch
from
4f636fb to
1bb38c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we attempted to update to a new version of Ruby, this Mailer
stopped working.
We are not sure why, but switching to positional arguments resolves the
issue, UserMailer uses positional arguments so we assume that this is
acceptable.
Making this refactor opens the door to update Ruby.