Skip to content

Conversation

@d3xter666
Copy link
Member

This PR enables the CI integration and build of the VitePress docs

JIRA: CPOUI5FOUNDATION-899

@d3xter666 d3xter666 requested a review from a team October 9, 2025 08:46
@d3xter666
Copy link
Member Author

A deployed version of the documentation with this pipeline can be seen here: https://d3xter666.github.io/test-mono/v5/

@maxreichmann
Copy link
Member

Looks very good. The only thing I could find is the home page linking to itself at the bottom as "Next Page":
Screenshot 2025-10-09 at 12 52 00

@d3xter666 d3xter666 force-pushed the enable-documentation-ci branch from d3b1b6c to 17accac Compare October 10, 2025 11:02
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from 8961b0d to 7a2ce4f Compare October 10, 2025 11:39
@d3xter666 d3xter666 force-pushed the enable-documentation-ci branch from 80605b9 to d5ff8ad Compare October 10, 2025 11:42
maxreichmann
maxreichmann previously approved these changes Oct 10, 2025
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch 3 times, most recently from 7d5eba8 to 8beda5d Compare October 14, 2025 12:38
@d3xter666 d3xter666 force-pushed the enable-documentation-ci branch 2 times, most recently from 5f8211a to b1a1266 Compare October 14, 2025 13:16
@d3xter666 d3xter666 force-pushed the enable-documentation-ci branch from b1a1266 to 2d7e05b Compare October 17, 2025 06:21
@d3xter666 d3xter666 requested a review from a team October 17, 2025 13:28
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch 4 times, most recently from de2cb77 to e0aa321 Compare October 22, 2025 07:28
@d3xter666 d3xter666 force-pushed the enable-documentation-ci branch from 00151fc to 7974b8c Compare October 22, 2025 07:44
@d3xter666 d3xter666 requested a review from a team October 24, 2025 12:57
Base automatically changed from feat-enable-vitepress to main October 28, 2025 08:06
@d3xter666 d3xter666 dismissed maxreichmann’s stale review October 28, 2025 08:06

The base branch was changed.

@d3xter666 d3xter666 force-pushed the enable-documentation-ci branch from a85b6bf to 3ce1dc1 Compare October 28, 2025 08:09
@d3xter666
Copy link
Member Author

The result of the deployment can be seen here: https://d3xter666.github.io/ui5-tooling/v5/

@d3xter666 d3xter666 marked this pull request as draft October 30, 2025 13:46
@matz3
Copy link
Member

matz3 commented Oct 30, 2025

The result of the deployment can be seen here: https://d3xter666.github.io/ui5-tooling/v5/

The version dropdown doesn't seem to work properly, but it could be that this is just an issue with your deployment, as it uses a different repo name (ui5-tooling instead of cli). This also seems to be the reason why the image is not loaded on the index page.

@d3xter666
Copy link
Member Author

d3xter666 commented Oct 31, 2025

The result of the deployment can be seen here: https://d3xter666.github.io/ui5-tooling/v5/

The version dropdown doesn't seem to work properly, but it could be that this is just an issue with your deployment, as it uses a different repo name (ui5-tooling instead of cli). This also seems to be the reason why the image is not loaded on the index page.

Now all the links should be resolved relatively, based on the current deployment!
There are 2 deployments: v5 and next:

Note: v4 is not available in this repo

We must deploy twice with modified config as vitepress uses this information to build links and some links might get broken if we just use symlink for next as it used to be with the previous docs deployment.

Also the 404 redirect issues have been addressed. Now the behaviour is:

  • if the version exists, but the page does not- redirect to the 404 page
  • if the version doesn't exist, redirect to the stable version

@d3xter666 d3xter666 force-pushed the enable-documentation-ci branch from e2018d9 to b190624 Compare November 7, 2025 07:13
@d3xter666
Copy link
Member Author

The latest deployments with the JSDoc integration into the documentation package and moved CLI generation script can be seen here:

@d3xter666 d3xter666 requested a review from matz3 November 7, 2025 09:06
@d3xter666 d3xter666 merged commit 8e00f82 into main Nov 7, 2025
15 checks passed
@d3xter666 d3xter666 deleted the enable-documentation-ci branch November 7, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants