Use robot capabilities #3433
Open
Use robot capabilities #3433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmostrenko
requested review from
itsarune,
williamckha and
sauravbanna
as code owners
GrayHoang
approved these changes
Mar 8, 2025
williamckha
approved these changes
Mar 8, 2025
williamckha
requested changes
Mar 8, 2025
Comment on lines
+423
to
+428
| required bool robot_0 = 1; | ||
| required bool robot_1 = 2; | ||
| required bool robot_2 = 3; | ||
| required bool robot_3 = 4; | ||
| required bool robot_4 = 5; | ||
| required bool robot_5 = 6; |
There was a problem hiding this comment.
The number of robots will change when we move from div B to div A, so it would be better to consider a more flexible approach. Could we instead use a repeated uint32 field that stores the IDs of the robots that are broken?
itsarune
reviewed
Mar 22, 2025
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
Added the ability to state whether or not certain robots have broken dribblers, kickers, or chippers using checkboxes for each robot id under the Parameters widget in Thunderscope. For instance, if you check the checkbox for Robot 2's dribbler, Robot 2 shouldn't be assigned any tactics that involve dribbling. Also added tests for this functionality, and updated many tactics' required RobotCapabilities.
Testing Done
Added tests in sensor_fusion to check that when the protos used to describe which robots have broken dribblers/kickers/chippers are changed, the specific robot's unavailable capabilities are also changed accordingly. Also observed the correct robot behaviour in Thunderscope.
Resolved Issues
resolved #3371
Length Justification and Key Files to Review
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.hfile) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO(or similar) statements should either be completed or associated with a github issue