-
Notifications
You must be signed in to change notification settings - Fork 111
YAML Config Support Added #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
probably going to polish this after some field test. |
I have tested this on a robot: this is a prove to work config file:
|
ROBOT_MULTICAST_CHANNEL_REDIS_KEY, | ||
ROBOT_CHIP_PULSE_WIDTH_REDIS_KEY}; | ||
|
||
class YAMLReader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
ROBOT_CHIP_PULSE_WIDTH_REDIS_KEY}; | ||
|
||
class YAMLReader | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We treat acronyms as words in our code, so this class should be named as: YamlReader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, you probably also need to update robot diagnostics CLI
I will work on fixing that sometime this week |
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR was closed because it has been stalled for 5 days with no activity. |
Description
Implemented a way to use yaml instead of redis
Testing Done
wrote some unit test. Going to field test on Saturday?
Resolved Issues
resolves #3315
Length Justification and Key Files to Review
N/A
Review Checklist
It is the reviewers responsibility to also make sure every item here has been covered
.h
file) should have a javadoc style comment at the start of them. For examples, see the functions defined inthunderbots/software/geom
. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.TODO
(or similar) statements should either be completed or associated with a github issue