Skip to content

YAML Config Support Added #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

Mr-Anyone
Copy link
Contributor

@Mr-Anyone Mr-Anyone commented Feb 21, 2025

Description

Implemented a way to use yaml instead of redis

Testing Done

wrote some unit test. Going to field test on Saturday?

Resolved Issues

resolves #3315

Length Justification and Key Files to Review

N/A

Review Checklist

It is the reviewers responsibility to also make sure every item here has been covered

  • Function & Class comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the functions defined in thunderbots/software/geom. Similarly, all classes should have an associated Javadoc comment explaining the purpose of the class.
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue

@Mr-Anyone Mr-Anyone changed the title Redis nuke YAML Config Support Added Feb 21, 2025
@Mr-Anyone
Copy link
Contributor Author

probably going to polish this after some field test.

@Mr-Anyone
Copy link
Contributor Author

I have tested this on a robot:

this is a prove to work config file:

robot_id:             1
channel_id:           0
network_interface:    "wlan0"
kick_coeff:           0.275
kick_constant:        500
chip_pulse_width:     20000

@Mr-Anyone Mr-Anyone marked this pull request as ready for review March 2, 2025 01:13
@Mr-Anyone Mr-Anyone marked this pull request as draft March 15, 2025 06:55
ROBOT_MULTICAST_CHANNEL_REDIS_KEY,
ROBOT_CHIP_PULSE_WIDTH_REDIS_KEY};

class YAMLReader
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs docs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

ROBOT_CHIP_PULSE_WIDTH_REDIS_KEY};

class YAMLReader
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We treat acronyms as words in our code, so this class should be named as: YamlReader

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@itsarune itsarune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, you probably also need to update robot diagnostics CLI

@Mr-Anyone
Copy link
Contributor Author

I will work on fixing that sometime this week

Copy link
Contributor

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale Inactive pull requests label Apr 23, 2025
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Apr 28, 2025
@itsarune itsarune reopened this Apr 29, 2025
@github-actions github-actions bot removed the Stale Inactive pull requests label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Redis with a TOML configuration file for (per) robot constants
2 participants