feat: update file querying methods to support flat directory structur…#336
Merged
Merged
Conversation
…e for timelapse videos
dc8a76c to
6b52e77
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the RTC datachannel “query file” flow and filesystem utilities to support querying video files from either the existing nested recording directory layout (root/YYYYMMDD/HH/) or a flat directory layout intended for timelapse videos.
Changes:
- Extend
Conductor::SendFileResponseandQueryFileResponsesending to include aVideoModeto distinguish recording vs timelapse queries. - Replace “second newest file” lookup with
Utils::FindLatestCompleteFile(...)and update older/time-based queries to accept abase_dir. - Add flat-layout handling paths in
Utils::FindLatestCompleteFile,FindFilesFromDatetime, andFindOlderFiles.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/rtc/conductor.h |
Updates SendFileResponse signature to include video mode. |
src/rtc/conductor.cpp |
Routes queries to mode-specific base directories and includes mode in responses. |
src/common/utils.h |
Renames/extends file-query utility APIs to accept a base directory and adds FindLatestCompleteFile. |
src/common/utils.cpp |
Implements flat vs nested directory handling for latest/older/time-based file queries. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… timelapse videos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…e for timelapse videos