Fix string.find and string.match from unexpected explosions #86
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading the documentation for
string.find
and I noticed that in it's own documentation it reads:I see the definition defined as:
Perhaps the easiest solution for this would be to simply add optional return parameters as follows:
So this way, at least you know it might explode instead of blindly walking into an explosion.
Also:
I noticed that string.match could also blow up so I threw that in there.