-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Designed new API and simple example #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JohannesMeierSE
commented
Dec 10, 2024
•
edited
Loading
edited
- joint work of @insafuhrmann and @JohannesMeierSE
- Fulfills Chaining/Factory API for predefined kinds/types #24 and Create an easy example for the README #39
- All existing examples including OX and LOX are reworked to use the new factory API
- The factory API is provided for these types: primitive, top, bottom, function, class
- These types are not (yet) supported by the new factory API
- multiplicity types: I am not sure, whether we really need this type, we should not advertise it for v0.1, but rework/redesign/improve it for upcoming versions
- fixed parameter type: I am unsure at the moment, how to integrate it into the API, since each kind instance is specific for the current set of operators, e.g. there is a "Map kind" and another "List kind", which "both are FixedParameterKinds" (https://github.com/TypeFox/typir/pull/43/files#diff-06d7c3de2afd260ac79d91a52f56faacc286892f4786c7e7bfbd670494d97429R28)
…etOrCreate functions (since they are not supported/needed), moved new interfaces into existing kind files
insafuhrmann
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great joint work session @JohannesMeierSE and for the additions and fixes afterwards. The Functions escaped the renaming from predefined to factory, otherwise everything seems fine to me.
Thanks @insafuhrmann for the great joint working session! |
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.