Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designed new API and simple example #43

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Conversation

JohannesMeierSE
Copy link
Collaborator

@JohannesMeierSE JohannesMeierSE commented Dec 10, 2024

@JohannesMeierSE JohannesMeierSE marked this pull request as ready for review December 11, 2024 16:59
Copy link
Member

@insafuhrmann insafuhrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great joint work session @JohannesMeierSE and for the additions and fixes afterwards. The Functions escaped the renaming from predefined to factory, otherwise everything seems fine to me.

packages/typir/src/kinds/function/function-kind.ts Outdated Show resolved Hide resolved
@JohannesMeierSE JohannesMeierSE merged commit 54b0191 into main Dec 12, 2024
2 checks passed
@JohannesMeierSE
Copy link
Collaborator Author

Thanks @insafuhrmann for the great joint working session!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants