Skip to content

fix: Selection clicking editor padding #1717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 12, 2025
Merged

fix: Selection clicking editor padding #1717

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f2028aa
Changed block content to use bigger line height instead of padding
matthewlipski May 23, 2025
cc836b9
Updated PW snaps
matthewlipski May 23, 2025
3b92dcb
Made `:before` elements have 0 height
matthewlipski May 23, 2025
0d4af93
Removed unnecessary style
matthewlipski May 23, 2025
4b54b03
Made changes to merge into main
matthewlipski Jun 12, 2025
fe87d0c
Small changes
matthewlipski Jun 12, 2025
80564f4
Updated PW snaps
matthewlipski Jun 12, 2025
e7e10d9
Merge branch 'main' into click-editor-padding-fix
matthewlipski Jun 12, 2025
baef576
Small change
matthewlipski Jun 12, 2025
570ae75
Updated PW snaps
matthewlipski Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions packages/core/src/editor/Block.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,26 +15,9 @@ BASIC STYLES

.bn-block-content {
padding: 3px 0;
display: flex;
transition: font-size 0.2s;
width: 100%;
/*
because the content elements are display: block
we use flex to position them next to list markers
*/
}

/* We can't set `display: flex` on `.bn-block-content` while it has inline
content (see #1629). However, it's necessary to set alignment of blocks
without content as these can't use `text-align`, so this additional rule is
used. */
.bn-block-content:not(:has(.bn-inline-content)) {
display: flex;
}

.bn-block-content::before {
/* content: ""; */
transition: all 0.2s;
/*margin: 0px;*/
}

.bn-block-content.ProseMirror-selectednode > *,
Expand All @@ -44,6 +27,19 @@ used. */
outline: 4px solid rgb(100, 160, 255);
}

.bn-block-content::before {
content: "";
margin-right: 0;
transition: all 0.2s;
/* Workaround for selection issue on Chrome, see #1588 and also here:
https://discuss.prosemirror.net/t/mouse-down-selection-behaviour-different-on-chrome/8426
The :before element causes the selection to be set in the wrong place vs
other browsers. Setting no height fixes this, while list item indicators are
still displayed fine as overflow is not hidden. */
height: 0;
overflow: visible;
}

.bn-inline-content {
width: 100%;
}
Expand Down Expand Up @@ -175,7 +171,6 @@ NESTED BLOCKS
.bn-block-content::before {
margin-right: 0;
content: "";
display: inline;
}

/* Ordered */
Expand Down
Loading