Adding scroll bar to handle overflow of long network lists (#12706)

* Adding scroll bar to handle overflow of long network lists * set scroll property to auto * Add margin below scrollable network list
Tungez33 · Nov 15, 2021 · c84604b · c84604b
1 parent 2ced3a8
commit c84604b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 12 deletions.
diff --git a/ui/components/app/dropdowns/network-dropdown.js b/ui/components/app/dropdowns/network-dropdown.js
@@ -338,20 +338,23 @@ class NetworkDropdown extends Component {
             </div>
           ) : null}
         </div>
-        {this.renderNetworkEntry('mainnet')}
 
-        {this.renderCustomRpcList(rpcListDetail, this.props.provider)}
+        <div className="network-dropdown-list">
+          {this.renderNetworkEntry('mainnet')}
 
-        <div
-          className={classnames('network-dropdown-testnets', {
-            'network-dropdown-testnets--no-visibility': !shouldShowTestNetworks,
-          })}
-        >
-          {this.renderNetworkEntry('ropsten')}
-          {this.renderNetworkEntry('kovan')}
-          {this.renderNetworkEntry('rinkeby')}
-          {this.renderNetworkEntry('goerli')}
-          {this.renderNetworkEntry('localhost')}
+          {this.renderCustomRpcList(rpcListDetail, this.props.provider)}
+
+          <div
+            className={classnames('network-dropdown-testnets', {
+              'network-dropdown-testnets--no-visibility': !shouldShowTestNetworks,
+            })}
+          >
+            {this.renderNetworkEntry('ropsten')}
+            {this.renderNetworkEntry('kovan')}
+            {this.renderNetworkEntry('rinkeby')}
+            {this.renderNetworkEntry('goerli')}
+            {this.renderNetworkEntry('localhost')}
+          </div>
         </div>
 
         {this.renderAddCustomButton()}

diff --git a/ui/css/itcss/components/network.scss b/ui/css/itcss/components/network.scss
@@ -128,6 +128,12 @@
   width: 100%;
 }
 
+.network-dropdown-list {
+  max-height: 330px;
+  overflow-y: auto;
+  margin-bottom: 8px;
+}
+
 .network-dropdown-divider {
   width: 100%;
   height: 1px;