Use cbor-x instead of cbor-js for CBOR encoding/decoding #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlrichEckhardt
approved these changes
Jul 27, 2024
| @@ -33,7 +33,6 @@ | |||
| "devDependencies": { | |||
| "@eslint/js": "^9.7.0", | |||
| "@ianvs/prettier-plugin-sort-imports": "^4.3.1", | |||
| "@types/cbor-js": "^0.1.1", | |||
| this.content = cbor.decode(BinaryHelper.toArrayBuffer(buf)); | ||
| this.content = cbor.decode(buf); | ||
|
|
||
| // Ignore unknown CBOR tags |
There was a problem hiding this comment.
Not really unknown: Some of the JPEGs have data with tag #18 here, which is COSE_Sign1 according to this list off assigned CBOR tags. I'll add this link in the typed-binary branch.
There was a problem hiding this comment.
True, unknown as in „unknown by cbor-x“. The COSE data is supposed to be tagged according to the COSE RFC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to newer, well maintained library cbor-x that includes proper tagging support.
It's pretty straightforward. Only two adjustments were necessary:
src/cose/SigStructure.tsshows an example of CBOR encoding – it needs a special flag to properly encode Uint8Array to the format we need.src/jumbf/CBORBox.tsneeds to deal with the fact that cbor-x returns a specialTagobject when encountering CBOR tags it doesn't natively understand.