Skip to content

Use Buffer.from() instead of new Buffer() #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use Buffer.from() instead of new Buffer() #113

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0be31ab
Use Buffer.from() instead of new Buffer()
matiasleva Apr 27, 2020
200058a
Update package.json
matiasleva Apr 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ module.exports = {
h1.update(hmac.digest());
h1 = h1.digest();
var h2 = crypto.createHmac(hashAlg, secret);
h2.update(new Buffer(parsedSignature.params.signature, 'base64'));
h2.update(Buffer.from(parsedSignature.params.signature, 'base64'));
h2 = h2.digest();

/* Node 0.8 returns strings from .digest(). */
Expand Down