Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added download callbacks for hash checking and metadata #8449

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

qstokkink
Copy link
Contributor

Fixes #7540
Fixes #8390
Fixes #8448

This PR:

  • Adds stopping downloads after receiving metainfo.
  • Adds checking downloads after downloading completed.
  • Fixes missing translation for EnableWatchFolder.
  • Fixes the apispec annotations for add_download.

Notes:

  • I did not implement a context menu for stopping a download after receiving metainfo because I'm scared to screw it up 🙂
  • Because I was lazy in the past, I now had to add mocked DownloadManager instances to all tests that use Download.

@qstokkink qstokkink force-pushed the add_notif_cb_functionalities branch from 863f4ed to 0599bcc Compare February 21, 2025 12:27
@qstokkink qstokkink changed the title WIP: Added download callbacks for hash checking and metadata READY: Added download callbacks for hash checking and metadata Feb 21, 2025
@qstokkink qstokkink marked this pull request as ready for review February 21, 2025 12:32
@qstokkink qstokkink changed the title READY: Added download callbacks for hash checking and metadata Added download callbacks for hash checking and metadata Feb 21, 2025
@qstokkink qstokkink merged commit a941b4d into Tribler:main Feb 21, 2025
7 checks passed
@qstokkink qstokkink deleted the add_notif_cb_functionalities branch February 21, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants