Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docker build script to get the latest stable release #8440

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

qstokkink
Copy link
Contributor

Related to #6591

This PR:

  • Updates build.Dockerfile to provide the latest-stable full-GUI Tribler (instead of headless) experience for X.Org-supporting platforms, including the tray icon and webbrowser opening.

Docker containers aren't really supposed to be able to manipulate the host and Python webbrowser doesn't normally forward to external services. So, some funky stuff is happening:

  1. We fool Python into thinking the x-www-browser is installed. This is actually bash script that sends a org.freedesktop.portal.OpenURI.OpenURI event to the D-Bus with the URL it was called with.
  2. We inherit the X.Org files from disk (volume), X.Org environment variables, and the user id from the host. This allows the host to interpret D-Bus events as its own.
  3. (Side note) We also need network_mode: host to forward events, but we were already using this for networking anyway.
  4. We circumvent AppArmor to not block any D-Bus event (I would have appreciated a less priviledged approach - but I guess this will do for now).

I'll have to test if GitHub Packages correctly bundles this when it is built "for real" instead of locally on my machine. But, assuming there are no issues, this will be all I do for #6591 until the Tribler 8.2.0. milestone rolls around.

Added (compose) support to open webbrowser tabs and tray icons
@qstokkink
Copy link
Contributor Author

validate

@qstokkink qstokkink changed the title WIP: Updated docker build script to get the latest stable release READY: Updated docker build script to get the latest stable release Feb 18, 2025
@qstokkink qstokkink marked this pull request as ready for review February 18, 2025 09:03
@qstokkink qstokkink changed the title READY: Updated docker build script to get the latest stable release Updated docker build script to get the latest stable release Feb 18, 2025
@qstokkink qstokkink merged commit 12eb5ba into Tribler:main Feb 18, 2025
7 checks passed
@qstokkink qstokkink deleted the add_stable_docker branch February 18, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants