-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added (disabled) composition integration test #8439
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
85c7f12
to
6cda472
Compare
While debugging mysterious GitHub Action failure, found:
Fixed in this PR |
6cda472
to
e1725d0
Compare
Found another in output:
Fixed in this PR |
d94853b
to
e7ab5a5
Compare
e7ab5a5
to
9dd0cb7
Compare
Still not entirely sure why validate is failing on the Action, found another traceback:
Fixed in this PR |
😑 ok, so, apparently the GitHub Actions running REALLY doesn't like |
GitHub Actions, why? :-(
4676914
to
c1301ae
Compare
validate |
egbertbouman
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TorrentCheckerComponent
assuming that the database is always available.TriblerTunnelCommunity
not get the ltsession async inupdate_ip_filter
.test_stream
usingAsyncMock
forupdate_priorities
(should beMock
).test_download_manager
not mocking downloads correctly in two tests.The last three fixes were not intended, but I discovered them while trying to work out that GitHub Actions "segfaults" the integration tests when using
unittest.skip
.