Hash check on completion

[teddyrogers]

Tribler 8.0.7, feature request, on completion of a download it would be good to have an option, in settings, to complete a hash check on the torrent.

On a couple of torrents, that have completed and seeding at 100%, I forced a hash recheck and noticed the files were not really 100% complete. This could be related to issue #8382. However, it highlights having the option to complete hash checks on completion could identify missed or partially downloaded pieces. This may also help to prevent invalid pieces being sent out to peers.

[absolutep]

having the option to complete hash checks on completion

This feature is already present in BiglyBT and it lead to BiglyBT being a huge resource hog [Disk usage 100% and RAM].

I had to disable it for BiglyBT to perform normally.

I think it is far better to force recheck torrents ourselves when we have time.

[qstokkink]

Oops, I posted my earlier comment on the wrong issue 👴

What we can do for this issue is simply create a new config flag, defaulting to "off" (because of @absolutep's advice above). When we receive a "torrent finished" alert, we can then force a recheck here:

tribler/src/tribler/core/libtorrent/download_manager/download.py

Line 561 in 36bde01

def on_torrent_finished_alert(self, alert: lt.torrent_finished_alert) -> None: