Make authorizer work for nested relations #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for nested relations
|
@TriPSs , do you have any comment on this? |
|
View your CI Pipeline Execution ↗ for commit 39c1122
☁️ Nx Cloud last updated this comment at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently authorizer works more-or-less only one level down.
For example, if you have following entities:
Then if you try to fetch tasks along with their sub-tasks and sub-sub-tasks; the authorizer of
SubSubTaskDTOisn't used, nor is therelation.authused which can be defined atSubTaskDTOlevel for thesubSubTasksrelation.This PR fixes it - so that authorizers defined in nested DTOs are also called, if they exist.
P.S. For now this PR makes the fix only for read relations, but I can easily do it for update/remove relations resolvers too. @TriPSs just let me know if you're okay with the fix and be willing to merge this - then I'll finish the PR so it works for the other resolvers as well.