Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: trying to update deps #145

Merged
merged 4 commits into from
Dec 19, 2024
Merged

chore: trying to update deps #145

merged 4 commits into from
Dec 19, 2024

Conversation

alvarosabu
Copy link
Member

No description provided.

@alvarosabu alvarosabu requested a review from userquin December 19, 2024 10:39
@userquin userquin self-assigned this Dec 19, 2024
@userquin
Copy link
Member

userquin commented Dec 19, 2024

The problem is the @tresjs/post-processing package, there is no default subpackage export and so resolvePath cannot resolve the real path (nuxt kit will check for the entry point) and will fail when reading the entry point to get the exports.

We can remove @tresjs/post-processing from the packages to read adding @tresjs/post-processing/three and @tresjs/post-processing/pnmdrs when @tresjs/post-processing found, but then we have some name collision:

image

We can change the names for those 3 components and the composable adding some hint to the docs.

@alvarosabu
Copy link
Member Author

Hi @userquin unfortunately that's not the only issue, the post processing one belong to #144 , if you downgrade the post processing here there are several issues with the client devtools and the playground with cientos

Copy link

pkg-pr-new bot commented Dec 19, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@tresjs/nuxt@145

commit: d1d78e0

@alvarosabu alvarosabu merged commit f19abcb into main Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants