Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fix select value bug when undefined #815

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

omerclskn
Copy link
Contributor

This PR fixes the problem of non-valued options appearing selected in select component.

Closes #625

@erbilnas
Copy link
Collaborator

erbilnas commented Mar 25, 2024

I believe it constitutes a breaking change. My mistake, I misread it

@Trendyol Trendyol locked and limited conversation to collaborators Mar 25, 2024
@Trendyol Trendyol unlocked this conversation Mar 25, 2024
@erbilnas erbilnas requested review from leventozen and erbilnas March 25, 2024 07:34
@erbilnas erbilnas added breaking change Be cautious with merging this and removed breaking change Be cautious with merging this labels Mar 25, 2024
@omerclskn
Copy link
Contributor Author

Sending "empty string" instead of null shoul be better. Otherwise it can break something.

empty string causes empty values to be set in single select too. my 3rd test in the test file is related to this case. so this bug is also related to single select.

@leventozen leventozen merged commit 474cd94 into next Mar 28, 2024
7 checks passed
@leventozen leventozen deleted the fix/625-select-empty-value-bug branch March 28, 2024 08:28
Copy link

🎉 This PR is included in version 3.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: multiple select option empty value
6 participants