Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): remove shadow from footer when scroll hits bottom #809

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

agursoyy
Copy link
Contributor

@agursoyy agursoyy commented Mar 8, 2024

This PR removes box-shadow from the footer when scrolling to the end of the content.

Closes #624

@erbilnas erbilnas merged commit ae0cffd into next Mar 18, 2024
2 checks passed
@erbilnas erbilnas deleted the fix/624-dialog-footer-shadow branch March 18, 2024 15:06
Copy link

🎉 This PR is included in version 3.0.0-beta.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@muratcorlu
Copy link
Contributor

Hi guys! What’s up? I continue to follow the project, you are doing very well! 🚀

A friendly reminder: you need to merge main to next after every stable release to be able to continue with proper beta releases. Because you didn’t do that after v3.0 release, we still see v3.0.0-beta releases. (It should be v3.1.0-beta) for your information. @leventozen @AykutSarac

Greetings! 👋🏼

Copy link

github-actions bot commented May 2, 2024

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialog content scroll shadow should be visible only if content scrollable on that side
4 participants