Repository navigation
feat(stepper): add stepper component - #1095
Merged
Merged
Conversation
erbilnas
changed the title
erbilnas
marked this pull request as draft
October 6, 2025 13:15
erbilnas
changed the title
fatihhayri
approved these changes
Oct 6, 2025
- Update type names: 'dots' -> 'dot', 'numbers' -> 'number', 'icons' -> 'icon' - Add hover variant support for interactive states - Refactor connector rendering from pseudo-elements to explicit DOM elements - Add showLeadingConnector and showTrailingConnector properties for proper connector visibility - Fix indicator alignment and sizing (32px circle, 10px dot, 18px icon) - Add connector placeholder for consistent horizontal alignment - Ensure dot and number types never show icons (only icon type shows icons) - Center align icons within indicators - Update CSS colors, spacing, and typography to match design specs - Update stories and tests with new type names - Fix stylelint and prettier issues
erbilnas
marked this pull request as ready for review
December 1, 2025 11:48
Collaborator
Author
|
The only issue is that I saw, the lines between the stepper steps aren’t visible in Storybook. When I checked in the playground everything looked fine, so it seems to be a Storybook specific issue. Other than that, everything looks good. Thanks again for your hard work @dilandoogan 🚀 🙏 
|
erbilnas
requested review from
AykutSarac and
fatihhayri
and removed request for
fatihhayri
December 1, 2025 13:33
Contributor
|
The deployed Storybook looks fine on my side, so I was curious why it didn’t display correctly for you :( Since we built the component together, thank you as well! |
Collaborator
Author
|
Then let's move it to beta. The issue might be coming from my local environment. |
AykutSarac
requested changes
Dec 1, 2025
AykutSarac
requested changes
Dec 1, 2025
AykutSarac
approved these changes
Dec 25, 2025
buseselvi
requested review from
buseselvi
and removed request for
fatihhayri
December 25, 2025 10:25
buseselvi
approved these changes
Dec 25, 2025
|
🎉 This PR is included in version 3.4.0-beta.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.