Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bl-select): bl-select popover does not close in searchable bl-select components via dropdown icon #1052

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

fix(bl-select): bl-select popover does not close in searchable bl-select components via dropdown icon #1052

wants to merge 1 commit into from

Conversation

omrumbakitemiz
Copy link
Member

fixes #1051

@omrumbakitemiz omrumbakitemiz self-assigned this Mar 26, 2025
AykutSarac
AykutSarac requested changes Mar 26, 2025
View reviewed changes
src/components/select/bl-select.ts
<bl-icon
class="dropdown-icon open"
name="arrow_up"
@click=${(e: MouseEvent) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bl-icon shouldn't be used as button, or add proper role attributes for accessibility

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't prefer to use buttons, we have to ensure it's focusable with tab by setting the tab-index attribute

src/components/select/bl-select.ts
Comment on lines +464 to +467
@click=${(e: MouseEvent) => {
e.stopPropagation();
this._togglePopover();
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're repeating functions here, can you create a function for this outside of render function

src/components/select/bl-select.ts
Comment on lines +498 to +501
@click=${(e: MouseEvent) => {
e.stopPropagation();
this._togglePopover();
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

src/components/select/bl-select.ts
Comment on lines +507 to +510
@click=${(e: MouseEvent) => {
e.stopPropagation();
this._togglePopover();
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AykutSarac AykutSarac AykutSarac requested changes

@ozkersemih ozkersemih ozkersemih approved these changes

@dilandoogan dilandoogan dilandoogan approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@omrumbakitemiz omrumbakitemiz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: bl-select popover does not close in searchable bl-select components via dropdown icon
4 participants
@omrumbakitemiz @AykutSarac @ozkersemih @dilandoogan