Added static linking of the windows runtime#146
Merged
Conversation
|
This method of customising the runtime library results in warnings for every source file compiled: The better way to set a default for this value (and also preserve the ability to customise it at configure time) is to use the following which was introduced in cmake 3.15 (so no need to bump the required cmake version for the project): Techinically don't need the I suspect the build logs don't show any of these warnings because the build caching is swallowing them now and they showed up first time they ran in the pipeline. |
Contributor
Author
|
Thanks for the tip, I've updated it here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.