-
Notifications
You must be signed in to change notification settings - Fork 102
Integrate DuckDuckGo Tracker Radar data types into TrackerControl #493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: kasnder <[email protected]>
Co-authored-by: kasnder <[email protected]>
Co-authored-by: kasnder <[email protected]>
kasnder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting stuff. This feels like a job unfinished though. Why not also integrate DDG's list of tracker domains, too? Do they offer any categories, like Mozilla does? I don't think they do..
Great question! I focused on DDG's data type classifications (708 domains) rather than their full domain list (51,841+ domains) for a few reasons: Technical considerations:
What we integrated:
Possible future enhancement:
Would you like me to explore adding DDG domains that aren't already covered by X-Ray/Disconnect? Or is the current data type integration sufficient? |
|
No, not implement. Matching by different company names to determine data types appears fragile though. Probably not a good idea. |
|
Is this solution using general ddg tracker data, or lists used at their App Tracking Protection (ATP)? ATP lists would maybe be smaller and better fit with TC? https://github.com/duckduckgo/tracker-blocklists/tree/main/app I suppose at least following could be useful if not in use already? https://raw.githubusercontent.com/duckduckgo/tracker-blocklists/main/app/android-tds.json PS. Again writing these thoughts as non developer, but just cause love this app and wish to see it even improved. So sorry if this comment is useless. |
DuckDuckGo maintains a categorized list of 25+ data type classifications for tracker domains (Session Replay, Action Pixels, Federated Login, etc.). This PR integrates that data to show users what types of data each tracker collects.
Changes
Data Loading
ddg-data-types.csv(708 domains) from DuckDuckGo Tracker Radar to assetsTrackerList.loadDdgDataTypes()with proper handling of quoted fieldsaddTrackerDomain()Data Model
Trackerclass withdataTypesfield (List)UI Display
TrackersListAdapter.updateText()to show data types inline with tracker name"Google (2h ago)\nData collected: Advertising, Analytics, Action Pixels\n• domains..."data_collectedstring resourceExample Output
Before:
After:
Updated README credits for DuckDuckGo data types.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
dl.google.com/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx4608m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.13-bin/5xuhj0ry160q40clulazy9h7d/gradle-8.13/lib/gradle-daemon-main-8.13.jar(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.