Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
zpzjzj
force-pushed
the
codex/filesystem-parent-recovery
branch
from
November 16, 2026 09:03
05bfe59 to
645afa9
Compare
zpzjzj
marked this pull request as draft
November 17, 2026 06:05
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Restore missing parent directories at runtime in FilesystemStore, then retry the failed filesystem operation once:
NotFound.This handles directory disappearance without claiming why the directory disappeared, reconstructing deleted blobs, or changing missing-source error classification.
Includes filesystem regression tests for digest and string keys, failure boundaries, retry limits, reader lifetime, and fast/slow cache fill, plus filesystem-store troubleshooting documentation.
How was this verified?
b30bb2d4a5252f153285f7b5ec9f09f22e3a33e4.645afa9a28677afdc62c80b94ca7fb3abeee94be; the CI carrier was checked to differ only in its CI configuration.git diff --checkpassed.rustfmt --edition 2024 --checkusing the repository-pinnednightly-2026-08-26formatter.cargo +1.97.1 build --workspace --lockedandbazelisk build //:nativelink --config=nl-toolchain --config=nl-quiet --lockfile_mode=error --verbose_failures --jobs=8(Bazel 9.3.1).-Dwarnings: all workspace libraries/binaries, then thefilesystem_store_testandfast_slow_store_testtargets.rust_clippy_aspect/rustfmt_aspect, their check output groups,--@rules_rust//:clippy_flag=-Dwarnings, and--nocache_test_results.uploads_restore_removed_parent_directories,unref_restores_missing_temp_dir,publish_retries_once_and_preserves_previous_generation, andslow_fill_restores_removed_filesystem_directories. The exact patched source was restored and checked before rerunning the complete suites.clippy --workspace --all-targets --locked -- -Dwarningswas attempted but is blocked by an unchanged S3 test's deprecatedBehaviorVersion::v2026_01_12()call. No lint allowance or unrelated source fix was added.Risk
Retries are bounded to one and limited to
NotFound. Rename failures are ambiguous, so recovery checks source existence first. This does not make directory deletion or mount loss safe: concurrent external changes may still cause an ordinary I/O error. No configuration or protocol changes.AI assistance
OpenAI Codex assisted with the implementation, regression tests, documentation, PR description, and diff review under my direction. I have reviewed and understand the changes in this PR, including the bounded directory-recovery retries, source-existence checks, and publication and eviction failure behavior. I take responsibility for this contribution and can explain the changes during review.