Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Require typed missing-digest context before tagging missing inputs or requesting a client re-upload. Keep diagnostic stacks for other NotFound errors instead of trimming them as ordinary cache misses.
zpzjzj
force-pushed
the
codex/preserve-local-not-found-errors
branch
from
November 16, 2026 08:52
8944d29 to
1f2ee72
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Require
ErrorContext::MissingDigestbefore treating an input-preparationNotFoundas a missing CAS input. A local filesystem error must not acquire the missing-input tip or become aFailedPreconditionresponse asking the client to upload inputs again.Only trim the store error stack for typed digest misses, preserving diagnostic context for other
NotFounderrors.How was this verified?
Changed-file rustfmt (nightly-2026-08-26, edition 2024) and
git diff --checkpass. No local Rust builds or tests were run.The regressions cover untyped
NotFoundtagging, a worker error containing the missing-input tip without digest context, and preservation of an untyped store error stack. A typed FastSlowStore miss retains its digest and compact error, and the existing worker test still checksFailedPreconditionwith the digest detail for client re-upload.Public GitHub CI execution is blocked, not passing:
1f2ee721816da23a294fbc05399201b4cd1363ef.There is currently no public GitHub CI build, clippy, test, or red/green result for this SHA. Maintainer approval is still required; neither the PR-template check nor CLA success is a Rust validation result.
Risk
Untyped
NotFounderrors now retain their diagnostic stack and follow the existing worker internal-error path. Typed missing-input errors keep the existing client re-upload response. No config, wire format, storage layout, or directory recovery changes.AI assistance
OpenAI Codex drafted the implementation, regression tests, and PR description under my direction and assisted with diff review. I have reviewed and understand the changes in this PR, including the distinction between typed missing-digest errors and local filesystem errors and the client re-upload behavior. I take responsibility for this contribution and can explain the changes during review.