Skip to content

Preserve local NotFound errors during input preparation - #3199

Open
zpzjzj wants to merge 1 commit into
TraceMachina:mainfrom
zpzjzj:codex/preserve-local-not-found-errors
Open

zpzjzj wants to merge 1 commit into
TraceMachina:mainfrom
zpzjzj:codex/preserve-local-not-found-errors

Conversation

@zpzjzj

@zpzjzj zpzjzj commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Require ErrorContext::MissingDigest before treating an input-preparation NotFound as a missing CAS input. A local filesystem error must not acquire the missing-input tip or become a FailedPrecondition response asking the client to upload inputs again.

Only trim the store error stack for typed digest misses, preserving diagnostic context for other NotFound errors.

How was this verified?

Changed-file rustfmt (nightly-2026-08-26, edition 2024) and git diff --check pass. No local Rust builds or tests were run.

The regressions cover untyped NotFound tagging, a worker error containing the missing-input tip without digest context, and preservation of an untyped store error stack. A typed FastSlowStore miss retains its digest and compact error, and the existing worker test still checks FailedPrecondition with the digest detail for client re-upload.

Public GitHub CI execution is blocked, not passing:

  • CI / NativeLink and the other upstream PR workflows require maintainer approval for patch SHA 1f2ee721816da23a294fbc05399201b4cd1363ef.
  • The fork Actions page reports that workflows are not running due to the scale of Actions usage. Dispatch returns HTTP 422, "Actions has been disabled for this repository", even though the permissions API reports enabled and the workflow is active. No validation run was created.

There is currently no public GitHub CI build, clippy, test, or red/green result for this SHA. Maintainer approval is still required; neither the PR-template check nor CLA success is a Rust validation result.

Risk

Untyped NotFound errors now retain their diagnostic stack and follow the existing worker internal-error path. Typed missing-input errors keep the existing client re-upload response. No config, wire format, storage layout, or directory recovery changes.

AI assistance

OpenAI Codex drafted the implementation, regression tests, and PR description under my direction and assisted with diff review. I have reviewed and understand the changes in this PR, including the distinction between typed missing-digest errors and local filesystem errors and the client re-upload behavior. I take responsibility for this contribution and can explain the changes during review.

@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Nov 16, 2026 8:52am UTC
nativelink-aidm Ready Ready Preview Nov 16, 2026 8:52am UTC

Request Review

Require typed missing-digest context before tagging missing inputs or
requesting a client re-upload. Keep diagnostic stacks for other NotFound
errors instead of trimming them as ordinary cache misses.

This branch was successfully deployed

2 active deployments
Preview – nativelink — 1f2ee721 Deployed Nov 16, 2026 by vercel[bot]
Preview – nativelink-aidm — 1f2ee721 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant