Skip to content

fix(web): update Jest glob dependencies for DoS advisories - #3197

Merged
MarcusSorealheis merged 4 commits into
TraceMachina:mainfrom
MarcusSorealheis:fix/web-security-advisories
Nov 16, 2026
Merged

MarcusSorealheis merged 4 commits into
TraceMachina:mainfrom
MarcusSorealheis:fix/web-security-advisories

Conversation

@MarcusSorealheis

@MarcusSorealheis MarcusSorealheis commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

What and why

Update the web workspace's transitive glob dependencies from 10.5.0/13.0.7 to 14.0.6 and minimatch from 9.0.9/10.2.6 to 11.0.8 using bounded pnpm overrides. This addresses GHSA-3g3m-2fjr-6pw4 and GHSA-g3hv-75wg-m249 in Jest and coverage tooling, with regression tests that load the packages through their actual consumers.

GHSA-gcqx-w48m-w2h4 remains visible: deepmerge 4.3.1 is still the latest published release as of November 15, 2026. Its inherited-property poisoning behavior reproduces, but the dependency is used here to merge repository-controlled Jest configuration. No application request path was found, and no audit suppression is added.

How was this verified?

On macOS with Node 26.8.1 and pnpm 11.22.0:

  • Restored the original dependency graph and ran the new tests: three failed, showing continued directory reads after cancellation in glob 10.5.0 and excessive pattern expansion in both tested minimatch consumers. The fourth passed because glob 13.0.7 already includes the cancellation backport.
  • pnpm install --frozen-lockfile and an offline reinstall passed with the updated lockfile.
  • pnpm test --runInBand --coverage: all 66 tests passed, including ordinary glob matching and coverage instrumentation.
  • pnpm run build: both website and documentation builds passed.
  • Formatted the new test with pinned Prettier 3.8.5 using the CI hook's configuration discovery: pnpm --dir tools/pre-commit run prettier <absolute-test-path>, then pnpm --dir tools/pre-commit exec prettier --check <absolute-test-path>. The result matches CI's formatting output exactly; git diff --check passes.
  • Audit refreshed November 15: pnpm audit --json reports only the low-severity deepmerge advisory; pnpm audit --prod --json reports zero advisories.

Rust/Bazel builds were not rerun for this web dependency change.

Risk

These overrides cross dependency major versions, so the main risk is changed test discovery or coverage glob behavior. The full web test suite with coverage and both builds passed. The remaining deepmerge advisory is unresolved; this PR does not claim all three warnings are fixed.

AI assistance

Codex traced the dependency paths, checked upstream advisories, drafted the overrides and regression tests, and ran the verification above at the maintainer's request. Human code review is pending.


This change is Reviewable

@vercel

vercel Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nativelink Ready Ready Preview Nov 16, 2026 2:44pm UTC
nativelink-aidm Ready Ready Preview Nov 16, 2026 2:44pm UTC

Request Review

@MarcusSorealheis
MarcusSorealheis merged commit 6fac44a into TraceMachina:main Nov 16, 2026
11 of 12 checks passed

This branch was successfully deployed

2 active deployments
Preview – nativelink — 4ebe5024 Deployed Nov 16, 2026 by vercel[bot]
Preview – nativelink-aidm — 4ebe5024 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants