Repository navigation
fix(web): update Jest glob dependencies for DoS advisories - #3197
Merged
MarcusSorealheis merged 4 commits intoNov 16, 2026
Merged
MarcusSorealheis merged 4 commits into
MarcusSorealheis merged 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
palfrey
approved these changes
Nov 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Update the web workspace's transitive
globdependencies from 10.5.0/13.0.7 to 14.0.6 andminimatchfrom 9.0.9/10.2.6 to 11.0.8 using bounded pnpm overrides. This addresses GHSA-3g3m-2fjr-6pw4 and GHSA-g3hv-75wg-m249 in Jest and coverage tooling, with regression tests that load the packages through their actual consumers.GHSA-gcqx-w48m-w2h4 remains visible:
deepmerge4.3.1 is still the latest published release as of November 15, 2026. Its inherited-property poisoning behavior reproduces, but the dependency is used here to merge repository-controlled Jest configuration. No application request path was found, and no audit suppression is added.How was this verified?
On macOS with Node 26.8.1 and pnpm 11.22.0:
glob10.5.0 and excessive pattern expansion in both testedminimatchconsumers. The fourth passed becauseglob13.0.7 already includes the cancellation backport.pnpm install --frozen-lockfileand an offline reinstall passed with the updated lockfile.pnpm test --runInBand --coverage: all 66 tests passed, including ordinary glob matching and coverage instrumentation.pnpm run build: both website and documentation builds passed.pnpm --dir tools/pre-commit run prettier <absolute-test-path>, thenpnpm --dir tools/pre-commit exec prettier --check <absolute-test-path>. The result matches CI's formatting output exactly;git diff --checkpasses.pnpm audit --jsonreports only the low-severitydeepmergeadvisory;pnpm audit --prod --jsonreports zero advisories.Rust/Bazel builds were not rerun for this web dependency change.
Risk
These overrides cross dependency major versions, so the main risk is changed test discovery or coverage glob behavior. The full web test suite with coverage and both builds passed. The remaining
deepmergeadvisory is unresolved; this PR does not claim all three warnings are fixed.AI assistance
Codex traced the dependency paths, checked upstream advisories, drafted the overrides and regression tests, and ran the verification above at the maintainer's request. Human code review is pending.
This change is