Repository navigation
Serve the canonical empty digest in DedupStore::get_part - #3012
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
matdexir
marked this pull request as ready for review
October 22, 2026 14:41
matdexir
force-pushed
the
fix-dedup-zero-digest
branch
from
October 23, 2026 12:55
79c30da to
12b88f8
Compare
matdexir
had a problem deploying
to
cluster-ci-benchmark
October 23, 2026 12:55 — with
GitHub Actions
Failure
matdexir
temporarily deployed
to
cluster-ci-benchmark
October 23, 2026 12:55 — with
GitHub Actions
Inactive
matdexir
temporarily deployed
to
cluster-ci-benchmark
October 26, 2026 15:33 — with
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
cluster-ci-benchmark
October 28, 2026 01:15 — with
GitHub Actions
Inactive
MarcusSorealheis
had a problem deploying
to
cluster-ci-benchmark
October 28, 2026 01:15 — with
GitHub Actions
Failure
palfrey
had a problem deploying
to
cluster-ci-benchmark
November 5, 2026 12:09 — with
GitHub Actions
Failure
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 5, 2026 12:09 — with
GitHub Actions
Inactive
palfrey
requested changes
Nov 5, 2026
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 5, 2026 13:28 — with
GitHub Actions
Inactive
palfrey
had a problem deploying
to
cluster-ci-benchmark
November 5, 2026 13:28 — with
GitHub Actions
Failure
matdexir
had a problem deploying
to
cluster-ci-benchmark
November 8, 2026 09:49 — with
GitHub Actions
Failure
matdexir
had a problem deploying
to
cluster-ci-benchmark
November 12, 2026 16:00 — with
GitHub Actions
Failure
matdexir
had a problem deploying
to
cluster-ci-benchmark
November 12, 2026 16:00 — with
GitHub Actions
Failure
matdexir
had a problem deploying
to
cluster-ci-benchmark
November 12, 2026 16:00 — with
GitHub Actions
Error
palfrey
approved these changes
Nov 12, 2026
matdexir
had a problem deploying
to
cluster-ci-benchmark
November 16, 2026 10:14 — with
GitHub Actions
Failure
matdexir
temporarily deployed
to
cluster-ci-benchmark
November 16, 2026 10:14 — with
GitHub Actions
Inactive
matdexir
had a problem deploying
to
cluster-ci-benchmark
November 16, 2026 10:14 — with
GitHub Actions
Error
matdexir
had a problem deploying
to
cluster-ci-benchmark
November 16, 2026 10:50 — with
GitHub Actions
Failure
matdexir
temporarily deployed
to
cluster-ci-benchmark
November 16, 2026 10:50 — with
GitHub Actions
Inactive
palfrey
had a problem deploying
to
cluster-ci-benchmark
November 16, 2026 14:32 — with
GitHub Actions
Failure
palfrey
had a problem deploying
to
cluster-ci-benchmark
November 16, 2026 14:32 — with
GitHub Actions
Failure
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 16, 2026 14:32 — with
GitHub Actions
Inactive
palfrey
temporarily deployed
to
cluster-ci-benchmark
November 16, 2026 15:07 — with
GitHub Actions
Inactive
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Uncovered by the store topology conformance harness (#3010):
Since #2974,
DedupStore::updateskips writing aDedupIndexentry for the canonical zero-byte digest (is_zero_digest), andDedupStore::has_with_resultsreportsSome(0)for it. However,DedupStore::get_partonly short-circuited whenlength == Some(0), so an unbounded read (get_part(zero_digest, 0, None)) attempted to fetch and deserialize an index entry fromindex_storeand failed withCode::Internal.DedupStore::get_partnow also checksis_zero_digest(key.borrow())and immediately sends EOF, matchingFilesystemStore,CompressionStore, andDedupStore::update.How was this verified?
Extended
empty_cas_upload_does_not_publish_dedup_indexinnativelink-store/tests/dedup_store_test.rsto asserthas(digest) == Some(0)andget_part_unchunked(digest, 0, None) == Bytes::new()for allZERO_BYTE_DIGESTS. Without the change indedup_store.rs,get_part_unchunkedfails trying to read the missing index entry; with the change, it succeeds.Risk
Low. Only affects reads of the canonical zero-byte digest on
DedupStore.AI assistance
Found via the store conformance harness and drafted with Cursor Agent; reviewed and verified.