Repository navigation
Conversation
Added an opt in "discard_failed_results" setting to the AC store config. When it is enabled requests whose result has a non zero exit code are acknowledged but not stored. Fixes TraceMachina#321
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thanks for this, the approach looks right to me. A few notes:
Context: workers already default to |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Added a new field to AcStoreConfig that makes the AC server acknowledge "UpdateActionResult" requests that have a non zero exit code without caching them.
Why? So that failures caused by something temporary don't get cached.
Fixes #321
How was this verified?
Two new tests in ac_server_test.rs. With the option on, a failed result isn't stored, and a successful one still is. I checked the test by altering line 150: && action_result.exit_code != 0 to && action_result.exit_code >= 0 and the test caught it (the success test failed).
Risk
The setting is off by default so risk is low. The only issue is that when it's on genuine failures are also rerun which is slower.
AI assistance
Claude drafted everything, I reviewed every line