Allow setting files UNIX permissions #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Touffy
requested changes
Mar 13, 2025
There was a problem hiding this comment.
Thank you for this PR.
Please update src/index.ts and index.d.ts to document the new mode field in input types. The types in src/input.ts are for internal use (and if you follow my recommendation about setting a mode in normalizeInput, mode will not be optional for them).
(edit: I see that you were doing just that as I was writing my review)
Touffy
approved these changes
Mar 14, 2025
Touffy
added a commit
that referenced
this pull request
Mar 14, 2025
Allow setting files UNIX permissions
|
Thanks again for your contribution. I have published the new versions on NPM, and a new release here. |
That's great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set file mode (UNIX permissions) for files to zip. I needed it mostly for executable bit, but decided to add more general
modeparameter. I did not test my changes too thoroughly, but they work for me (running it in a Cloudflare worker). Thanks for the library btw, needed exactly what it does!