Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESlint with react-hooks/exhaustive-deps #7482

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

mateuszkp96
Copy link
Contributor

Describe your changes

We decided to enable ESlint for missing dependencies for React hooks to prevent bugs caused by missing dependencies.

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Jan 21, 2025
@mateuszkp96 mateuszkp96 requested a review from Dzuming January 21, 2025 14:33
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mateuszkp96 mateuszkp96 merged commit d4ea5e8 into staging Jan 22, 2025
13 checks passed
@mateuszkp96 mateuszkp96 deleted the es-lint-exhaustive-deps branch January 22, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants