-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NU-1962] Flink scenario testing mechanism: mini cluster created once and reused each time #7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
2 times, most recently
from
January 15, 2025 14:37
ff55969
to
327b22b
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 16, 2025 11:23
327b22b
to
107d3a2
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 16, 2025 13:54
40808c0
to
e2cb08a
Compare
…k for empty classpath
… jobGraph.getJobConfiguration to mini cluster
…m production code to test code
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 17, 2025 13:43
81d95d8
to
a2f1899
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 20, 2025 13:26
a9e4a09
to
8118f73
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 20, 2025 14:54
23cfd43
to
22f432f
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 20, 2025 15:52
a014bc6
to
e63a246
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 21, 2025 09:48
752c3c2
to
09a5efb
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 21, 2025 10:29
53f352f
to
6325dc4
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
2 times, most recently
from
January 23, 2025 20:34
80c0a8e
to
32ff95d
Compare
arkadius
force-pushed
the
flink-test-mechanism-caching
branch
from
January 23, 2025 21:55
32ff95d
to
16fd8a6
Compare
raphaelsolarski
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I left a few minor comments.
PS. I see that some code (tests/pr) is commented out.
...test-utils/src/main/scala/pl/touk/nussknacker/engine/flink/test/FlinkTestConfiguration.scala
Show resolved
Hide resolved
engine/flink/management/src/main/scala/pl/touk/nussknacker/engine/management/FlinkConfig.scala
Show resolved
Hide resolved
...management/src/main/scala/pl/touk/nussknacker/engine/management/FlinkDeploymentManager.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merge