Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NU-1962] Flink scenario testing mechanism: mini cluster created once and reused each time #7458

Merged
merged 53 commits into from
Jan 25, 2025

Conversation

arkadius
Copy link
Member

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@arkadius arkadius force-pushed the flink-test-mechanism-caching branch 2 times, most recently from ff55969 to 327b22b Compare January 15, 2025 14:37
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from 327b22b to 107d3a2 Compare January 16, 2025 11:23
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from 40808c0 to e2cb08a Compare January 16, 2025 13:54
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from 81d95d8 to a2f1899 Compare January 17, 2025 13:43
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from a9e4a09 to 8118f73 Compare January 20, 2025 13:26
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from 23cfd43 to 22f432f Compare January 20, 2025 14:54
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from a014bc6 to e63a246 Compare January 20, 2025 15:52
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from 752c3c2 to 09a5efb Compare January 21, 2025 09:48
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from 53f352f to 6325dc4 Compare January 21, 2025 10:29
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch 2 times, most recently from 80c0a8e to 32ff95d Compare January 23, 2025 20:34
@arkadius arkadius force-pushed the flink-test-mechanism-caching branch from 32ff95d to 16fd8a6 Compare January 23, 2025 21:55
@raphaelsolarski raphaelsolarski self-requested a review January 24, 2025 10:03
Copy link
Contributor

@raphaelsolarski raphaelsolarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I left a few minor comments.
PS. I see that some code (tests/pr) is commented out.

@arkadius arkadius merged commit 0f1ccfb into staging Jan 25, 2025
19 checks passed
@arkadius arkadius deleted the flink-test-mechanism-caching branch January 25, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants