-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add taskvine executor to topeft #460
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 25.29% 25.14% -0.16%
==========================================
Files 31 31
Lines 4977 4991 +14
==========================================
- Hits 1259 1255 -4
- Misses 3718 3736 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @btovar. I left a few minor style comments, but feel free to ignore them.
|
||
args = parser.parse_args() | ||
jsonFiles = args.jsonFiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the style where they line up too. However, I got tired of fighting black/flake8 as that's not the officially enforced style.
@@ -32,85 +32,174 @@ | |||
"nSumOfWeights_renormfactDown", | |||
] | |||
|
|||
if __name__ == '__main__': | |||
|
|||
parser = argparse.ArgumentParser(description='You can customize your run') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like this older style, but I guess the newer style ensures every line fits on the screen?
Depends on:
coffea==0.7.26
and:
TopEFT/topcoffea#64