Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add taskvine executor to topeft #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add taskvine executor to topeft #460

wants to merge 1 commit into from

Conversation

btovar
Copy link
Contributor

@btovar btovar commented Mar 13, 2025

Depends on:
coffea==0.7.26

and:
TopEFT/topcoffea#64

Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 67.44186% with 42 lines in your changes missing coverage. Please review.

Project coverage is 25.14%. Comparing base (3471b74) to head (05044e6).

Files with missing lines Patch % Lines
analysis/topeft_run2/run_analysis.py 67.44% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   25.29%   25.14%   -0.16%     
==========================================
  Files          31       31              
  Lines        4977     4991      +14     
==========================================
- Hits         1259     1255       -4     
- Misses       3718     3736      +18     
Flag Coverage Δ
unittests 25.14% <67.44%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bryates bryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @btovar. I left a few minor style comments, but feel free to ignore them.


args = parser.parse_args()
jsonFiles = args.jsonFiles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally like this older style where the = lined up, but it's not something I'll force. What do @Andrew42 and @sscruz think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the style where they line up too. However, I got tired of fighting black/flake8 as that's not the officially enforced style.

@@ -32,85 +32,174 @@
"nSumOfWeights_renormfactDown",
]

if __name__ == '__main__':

parser = argparse.ArgumentParser(description='You can customize your run')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like this older style, but I guess the newer style ensures every line fits on the screen?

@bryates bryates requested review from sscruz and Andrew42 March 13, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants