Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3l fwd #452

Open
wants to merge 117 commits into
base: master
Choose a base branch
from
Open

3l fwd #452

wants to merge 117 commits into from

Conversation

bryates
Copy link
Contributor

@bryates bryates commented Dec 16, 2024

Adding new 3l forward jet regions, as talked about in the last meeting. Most of this will isolate the extra parton in the ttW process, but the new 1 jet forward region is designed to isolate the single-top spectator quark.

@@ -721,6 +721,10 @@ def process(self, events):
preselections.add("2lss_fwd", (events.is2l & pass_trg & fwdjet_mask))
preselections.add("2l_fwd_p", (chargel0_p & fwdjet_mask))
preselections.add("2l_fwd_m", (chargel0_m & fwdjet_mask))
preselections.add("3l_fwd", (events.is3l & pass_trg))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bryates This is perhaps a minor thing. I see that you include the fwdjet_mask in ch_lst_test.json instead of in the 3l_fwd mask in the processor. But 2lss_fwd fwdjet_mask does the other way. Do we want to keep the selection codes for 2lss_fwd and 3l_fwd more consistent just to be easier for others to read/understand?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. Let's move it to the json file for 2lss, that way keep the processor a bit more generalized.

@@ -32,15 +32,15 @@ def __init__(self, samples):
jeta_axis = hist.axis.Regular(25, -2.5, 2.5, name="eta", label=r"Jet \eta (GeV)")
jaeta_axis = hist.axis.Variable([0, 1, 1.8, 2.4], name="abseta", label=r"Jet \eta (GeV)")
Flav_axis = hist.axis.StrCategory([], name="Flav", growth=True)
flav_axis = hist.axis.IntCategory([], name="flav", growth=True)
flav_axis = hist.axis.Regular(5, 0, 5, name="flav", label="jet flav")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ywan2 did you push these change by accident?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These I pushed by accident. Sorry about it! Although it does fix the script to run, but I think I will make these changes in another branch to avoid confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sounds like a good plan.

@bryates
Copy link
Contributor Author

bryates commented Mar 25, 2025

@ywan2
Copy link
Contributor

ywan2 commented Mar 25, 2025

@ywan2 was this intended? 8ebdfb1#diff-c51d434110b01b664b71f73a6904805333c86530877d042306c36580b00ebd73L724

If you check the ch_lst_test.json file here, you can see that these masks are actually redundant and can be removed.

@bryates
Copy link
Contributor Author

bryates commented Mar 25, 2025

@ywan2 was this intended? 8ebdfb1#diff-c51d434110b01b664b71f73a6904805333c86530877d042306c36580b00ebd73L724

If you check the ch_lst_test.json file here, you can see that these masks are actually redundant and can be removed.

Ok thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants