fixed: mineral handling #703
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moved handleReaction to prototype_room_mineral.js added Room.prototype.getEnergy
TooAngel
reviewed
Feb 25, 2023
- reduce findMyCreepsOfRole - remove duplicate if's - fast return
mschultheiss83
added a commit
to mschultheiss83/screeps
that referenced
this pull request
Feb 26, 2023
- buyEnergy if we have terminals and storage, mineral creeps should move energy to storage for builders and upgrader sell PR TooAngel#703 - fixed quests.js for incoming transactions
|
basically thats the first part of mineral getting back to work |
TooAngel
requested changes
Feb 26, 2023
| if (lab0 === null || lab1 === null || lab2 === null) { | ||
| delete this.memory.reaction; | ||
| return false; | ||
| } else { |
There was a problem hiding this comment.
Suggested change
| } else { | |
| } |
(move the } up)
The if clause ends with a return. It is a bit easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved handleReaction to prototype_room_mineral.js
added Room.prototype.getEnergy