feat: allow features command to run without commands or multiple folders#52
Closed
shakaran wants to merge 10 commits intoTomasVotruba:mainfrom
Closed
feat: allow features command to run without commands or multiple folders#52shakaran wants to merge 10 commits intoTomasVotruba:mainfrom
shakaran wants to merge 10 commits intoTomasVotruba:mainfrom
Conversation
- Modified FeaturesCommand to reassign SymfonyStyle in execute() with correct input/output streams for proper test output capture. - Updated ResultPrinter to accept SymfonyStyle as a parameter in print() method. - Changed command title from "Collected features" to "PHP features". - Updated test assertions to check for "PHP features" in output. - Ensured SymfonyStyle is used from constructor property, reassigned in execute() to meet requirements. This resolves the issue where CommandTester was not capturing console output due to incorrect SymfonyStyle streams.
* Fix throw expression detection. Requires adding ParentConnectingVisitor to node traverser * Introduce ThrowExpressionFlaggingNodeVisitor Replaces the ParentConnectingVisitor in an attempt to reduce memory usage. * Fix phpstan errors * Stop relying on parent in throw flagging visitor * Fix phpstan errors * Bring all throw expr detection logic back into FeatureCollector
* fixed ordered imports CS issue * apply ClosureReturnTypeRector rule * fix issue TomasVotruba#61
- Modified FeaturesCommand to reassign SymfonyStyle in execute() with correct input/output streams for proper test output capture. - Updated ResultPrinter to accept SymfonyStyle as a parameter in print() method. - Changed command title from "Collected features" to "PHP features". - Updated test assertions to check for "PHP features" in output. - Ensured SymfonyStyle is used from constructor property, reassigned in execute() to meet requirements. This resolves the issue where CommandTester was not capturing console output due to incorrect SymfonyStyle streams.
Owner
|
I've cherry picked your commit and rebased in #66 👍 Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #50