Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/develop' into next_release
Browse files Browse the repository at this point in the history
  • Loading branch information
jalazawa committed Nov 15, 2017
2 parents ebb83a2 + 00c7851 commit 6e42b54
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# manipulateWidget 0.8.0 (2017-10-25)

## New features
* `manipulateWidget()` has a new parameter `.updateBtnInit`. In case of update button `.updateBtn`, you can decideto render graphics on init or not.
* UI has now a button to save the current chart in an HTML file (thanks to Benoit Thieurmel).`manipulateWidget`gains a new parameter ".saveBtn" to show or hide this button.
* `manipulateWidget()` has a new parameter ".runApp". If it is false, then the function returns an object of class `MWController` that can be modified using command line instructions. This is useful to write tests for UIs created with `manipulateWidget()`.
* `manipulateWidget` interfaces can now be included in shiny applications thanks to the two new functions `mwModule()` and `mwModuleUI()`.
Expand Down
8 changes: 4 additions & 4 deletions tests/testthat/test-staticPlot.R
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ describe("Static plot & image", {
expect_is(c, "combineWidgets")
expect_length(c$widgets, 2)

# check saveWidget and so preRenderCombinedWidgets
tmp_html <- tempfile(fileext = ".html")
htmlwidgets::saveWidget(c, tmp_html)
expect_true(file.exists(tmp_html))
# # check saveWidget and so preRenderCombinedWidgets
# tmp_html <- tempfile(fileext = ".html")
# htmlwidgets::saveWidget(c, tmp_html)
# expect_true(file.exists(tmp_html))

})
})

0 comments on commit 6e42b54

Please sign in to comment.