Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
idwas present in the import payload, causing validation errors like{'id': ['Segment (Who) with this ID already exists.']}.Description
TreeNodeImporter.import_treeto collectids for each depth level and load existing objects within_bulkto decide between update vs create._depthand_pathandid) to the model instance, validates withfull_clean()and callssave()to persist updates.bulk_create, and counterscreatedandupdatedare maintained in the importresult.TreeNodeImporterTests.test_importer_updates_existing_object_when_id_presentto ensure importer updates an object whenidis provided instead of attempting to re-create it.Testing
python -m pytest -q, which completed successfully with15 passed, 1 skipped(and 3 warnings).Codex Task