Open
Conversation
Contributor
Author
|
I will also mention I am uncertain for how to implement the test as Gulrak said, but I believe the test should suffice as it does complete properly on Cadmium's VIP core. |
Contributor
Author
|
Apparently line endings got changed. Sorry about that! |
Timendus
reviewed
Jul 26, 2025
Owner
Timendus
left a comment
Timendus
left a comment
There was a problem hiding this comment.
Thanks for taking the time to jump on this issue! And sorry for not responding sooner. My priorities have shifted a bit.
Your PR takes a bit more love and effort to review properly. So either it will have to wait until I have a bit more time, or maybe Gulrak can take a look himself? If you both agree that this works well and that the implementation is solid, I'm fine with merging it blindly :)
|
@gulrak, do you have some time to review this for us? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decided to take some time out of my day to implement the CxNN test that I saw the ideas for in #5.
The way I implemented it here is as follows:
0Fwill always return a value in the range of00 - 0FF0will always return a value in the range of00 - F0, and that the lower nibble is never affectedI am aware that the file has a bunch of deletions, and I am certain that is due to Windows notepad formatting the file weirdly. Once that is fixed, this should be ready to merge.