Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve performance of Bavet indexing #1324

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jan 15, 2025

Refactors indexing in Bavet so that:

  • IndexKeys (formerly IndexProperties) become bimorphic as opposed to megamorphic, enabling all kinds of JVM optimizations.
  • Many instances of IndexKeys are no longer created as they were unnecessary. (Case in point: SingleIndexProperties is gone, without replacement.)
  • There is less indirection in the nodes.
  • Naming of keys, functions and mappings is standardized across the board.

In the score director benchmarks, these changes show throughput improvements of up to 10 %, with GC pressure reduced by up to 40 %.

@triceo
Copy link
Contributor Author

triceo commented Jan 15, 2025

Please review after we're done with the release, @zepfred.
You have already seen most of these changes before, in the commit that was originally reverted.

@triceo triceo marked this pull request as ready for review January 15, 2025 11:02
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@triceo triceo merged commit c42acc7 into TimefoldAI:main Jan 16, 2025
27 of 28 checks passed
@triceo triceo deleted the index branch January 16, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants