This repository has been archived by the owner on Jul 17, 2024. It is now read-only.
chore: Implement IncrementalScoreCalculator using classes instead of decorators #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…decorators - Since there can only be one function signature in Python, and Java allows many, it might be the case that the top function signature in Python does not match its parent's function signature. Since the interface calls the parent's function signature, the wrong method would be called. To prevent this, we need to look up the 'canonical' method of the type, which is conveniently stored as an attribute on the type. - Fix a bug in function __get__ descriptor; in particular, when called on a type, it should return the unbounded function instead of binding the function to the type. - Make the ABC check less strict. In particular, only collections.abc and Protocol are banned, since collections.abc contain classes that should be Protocols but are instead ABC, and Protocols only define the structure and do not play a part in type hierarchy.
triceo
approved these changes
Apr 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there can only be one function signature in Python, and Java allows many, it might be the case that the top function signature in Python does not match its parent's function signature. Since the interface calls the parent's function signature, the wrong method would be called. To prevent this, we need to look up the 'canonical' method of the type, which is conveniently stored as an attribute on the type.
Fix a bug in function get descriptor; in particular, when called on a type, it should return the unbounded function instead of binding the function to the type.
Make the ABC check less strict. In particular, only collections.abc and Protocol are banned, since collections.abc contain classes that should be Protocols but are instead ABC, and Protocols only define the structure and do not play a part in type hierarchy.