Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

feat: Add support for custom justifications #39

Merged
merged 4 commits into from
Apr 24, 2024
Merged

feat: Add support for custom justifications #39

merged 4 commits into from
Apr 24, 2024

Conversation

Christopher-Chianelli
Copy link
Collaborator

  • Added a way to specify a class implements a Java marker interface. For interfaces with methods, further work is needed.

@Christopher-Chianelli
feat: Add support for custom justifications
43a59bd 
- Added a way to specify a class implements a Java marker
  interface. For interfaces with methods, further work is needed.
triceo
triceo reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do that "further work" first, because otherwise we can not be sure we'll be able to maintain backwards compatibility of the API we're publishing here.

jpyinterpreter/src/main/python/annotations.py Outdated Show resolved Hide resolved
jpyinterpreter/tests/test_classes.py Outdated Show resolved Hide resolved
timefold-solver-python-core/src/main/python/api/_solution_manager.py Outdated Show resolved Hide resolved
triceo
triceo approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see some more tests for the general mechanism - specifically, what happens with default methods, static methods and static fields on interfaces.

After that, LGTM.

@Christopher-Chianelli Christopher-Chianelli merged commit 45132a1 into TimefoldAI:main Apr 24, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@triceo triceo triceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Christopher-Chianelli @triceo