Skip to content

SVG Support#27

Open
shaunpatterson wants to merge 10 commits into
TimBeyer:masterfrom
shaunpatterson:master
Open

SVG Support#27
shaunpatterson wants to merge 10 commits into
TimBeyer:masterfrom
shaunpatterson:master

Conversation

@shaunpatterson
Copy link
Copy Markdown

Incorporates #22

Added a few extra tests for more code coverage

@TimBeyer
Copy link
Copy Markdown
Owner

Hey, thanks a lot for the extended PR.
What I'm really missing to finally merge the SVG support is to follow the more modular structure I introduced in #21

Currently the SVG handling is kind of a regression code-wise, at the same time leaving the modules lying around as orphaned code.

Once that is taken care of I'll gladly merge this.

@TimBeyer
Copy link
Copy Markdown
Owner

TimBeyer commented Mar 9, 2016

Hey @spattersongt, sorry I never got back to you.
To be honest, I just never noticed you pushed some additional commits.

I promise I'll review this in the coming days.
Your contribution is much appreciated :)

@TimBeyer TimBeyer self-assigned this Mar 9, 2016
@feelic
Copy link
Copy Markdown

feelic commented Jun 2, 2016

This would be awesome to have, is there anything I could do to help with it ?

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 20, 2016

Coverage Status

Coverage decreased (-5.2%) to 94.764% when pulling 0a4d5ec on spattersongt:master into 42c1229 on TimBeyer:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 20, 2016

Coverage Status

Coverage decreased (-5.2%) to 94.764% when pulling 0a4d5ec on spattersongt:master into 42c1229 on TimBeyer:master.

@Jarred-Sumner
Copy link
Copy Markdown

Jarred-Sumner commented Oct 6, 2016

Something I'm working on depends on inline SVG support, and I'd love to use this library. What are the next steps on this PR?

@jxm262
Copy link
Copy Markdown

jxm262 commented Jan 21, 2017

👍 Chiming in along with the other commenters, is there any plans to merge this? Or if there's still specific issues with the PR, is there anything I can do to help?

For the meantime I'm going to use the fork from @shaunpatterson

* -fixing lint errors
-adding tests

* fixing test

* removing unncessary attribute checks
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling e65af81 on shaunpatterson:master into 42c1229 on TimBeyer:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants