Skip to content

Enablement on ROCm #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enablement on ROCm #71

wants to merge 3 commits into from

Conversation

rraminen
Copy link

@rraminen rraminen commented Feb 12, 2025 •
edited
Loading

This PR contains the below two changes

  1. forceinline needs inline and always_inline on ROCm
  2. extra_include_paths is required for the hipification of quant_cuda header files.

@rraminen rraminen changed the title __forceinline__ needs inline and always_inline on ROCm Enablement on ROCm Feb 14, 2025
@rraminen rraminen marked this pull request as ready for review February 14, 2025 22:32
@rraminen
Copy link
Author

rraminen commented Mar 7, 2025

Hi @Tiiiger, could you please review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rraminen