feat(diacritics): Russian/Ukrainian/Belarusian stress as add_diacritics backends by JarbasAl · Pull Request #187 · TigreGotico/phoonnx

JarbasAl · 2026-06-08T20:32:57Z

Word stress is a pronunciation-disambiguating diacritic mark (same category as Arabic tashkeel / Hebrew niqqud), so it's a backend of the generic add_diacritics, not a separate flag.

BasePhonemizer.add_diacritics now routes lang ru/uk/be to a stress accentuator (stressonnx), best-effort (warn + identity if absent), alongside ar→tashkeel and he→niqqud. VoiceConfig auto-enables add_diacritics for those langs. Adds SynthesisConfig.diacritics_model (variant selector, e.g. silero vs ruaccent for ru), forwarded only when the backend's signature accepts it.

No new flag. 16 new tests, 262 passed.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

…d stress Routes lang_code starting with ru/uk/be to `stressonnx.stress` inside the existing `BasePhonemizer.add_diacritics` dispatch (same generic flag as Arabic tashkeel / Hebrew niqqud — no new SynthesisConfig field). Adds optional `SynthesisConfig.diacritics_model` to select the stressonnx model variant (e.g. "silero"/"ruaccent"); forwarded only when the backend's signature accepts it, so it is safely ignored on older installs. Auto-enables `VoiceConfig.add_diacritics` for ru/uk/be (mirrors existing ar behaviour) in both `__post_init__` and the Piper `from_dict` branch. The stressonnx backend is best-effort: an ImportError or runtime exception logs a warning and returns the original text unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

coderabbitai · 2026-06-08T20:33:05Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 00376350-3cfe-465c-9bd0-41abebf22de8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/stress

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-08T20:33:42Z

Hello there! I've processed your latest changes. 🌊

I've aggregated the results of the automated checks for this PR below.

🔍 Lint

The data has been harvested! Check the findings below. 🌾

❌ ruff: issues found — see job log

🔒 Security (pip-audit)

Checking if we're following security best practices. 📏

✅ No known vulnerabilities found (61 packages scanned).

📊 Coverage

Is the code fully immunized with tests? 💉

❌ 41.8% total coverage

Files below 80% coverage (43 files)

File	Coverage	Missing lines
`phoonnx/cli.py`	0.0%	98
`phoonnx/thirdparty/kog2p/__init__.py`	0.0%	203
`phoonnx/thirdparty/mantoq/unicode_symbol2label.py`	0.0%	1
`phoonnx/thirdparty/bw2ipa.py`	7.5%	86
`phoonnx/thirdparty/mantoq/pyarabic/number.py`	7.7%	371
`phoonnx/thirdparty/mantoq/buck/phonetise_buckwalter.py`	10.4%	180
`phoonnx/thirdparty/hangul2ipa.py`	16.6%	372
`phoonnx/phonemizers/en.py`	17.5%	104
`phoonnx/thirdparty/mantoq/pyarabic/trans.py`	18.2%	135
`phoonnx/model_manager.py`	19.2%	244
`phoonnx/thirdparty/zh_num.py`	23.1%	83
`phoonnx/thirdparty/tashkeel/__init__.py`	23.9%	89
`phoonnx/voice.py`	24.5%	231
`phoonnx/phonemizers/zh.py`	27.0%	92
`phoonnx/phonemizers/mul.py`	27.6%	234
`phoonnx/phonemizers/ko.py`	30.4%	32
`phoonnx/phonemizers/gl.py`	31.1%	42
`phoonnx/phonemizers/ar.py`	31.2%	44
`phoonnx/thirdparty/mantoq/buck/tokenization.py`	32.5%	27
`phoonnx/thirdparty/phonikud/__init__.py`	35.3%	11
`phoonnx/phonemizers/ja.py`	36.0%	32
`phoonnx/phonemizers/fa.py`	36.4%	14
`phoonnx/phonemizers/pt.py`	38.1%	13
`phoonnx/thirdparty/mantoq/pyarabic/normalize.py`	38.1%	13
`phoonnx/thirdparty/mantoq/pyarabic/araby.py`	39.7%	298
`phoonnx/engines/speaker_encoders/base.py`	40.0%	12
`phoonnx/phonemizers/he.py`	40.0%	12
`phoonnx/phonemizers/vi.py`	40.0%	12
`phoonnx/thirdparty/mantoq/pyarabic/stack.py`	45.5%	6
`phoonnx/engines/zipvoice.py`	46.9%	43
`phoonnx/thirdparty/mantoq/num2words.py`	47.6%	11
`phoonnx/phonemizers/mwl.py`	50.0%	8
`phoonnx/tokenizer.py`	52.4%	147
`phoonnx/phonemizers/base.py`	55.1%	62
`phoonnx/engines/speaker_encoders/styletts2_style.py`	57.1%	6
`phoonnx/thirdparty/mantoq/__init__.py`	60.0%	10
`phoonnx/thirdparty/mantoq/pyarabic/arabrepr.py`	60.0%	6
`phoonnx/engines/vocoders/griffinlim.py`	61.4%	27
`phoonnx/engines/speaker_encoders/coqui_resnet.py`	61.5%	5
`phoonnx/config.py`	67.6%	117
`phoonnx/engines/optispeech.py`	69.6%	24
`phoonnx/engines/speaker_encoders/__init__.py`	73.9%	6
`phoonnx/util.py`	78.9%	59

Full report: download the coverage-report artifact.

📋 Repo Health

Ensuring the repo's joints are well-oiled (aka CI/CD). ⚙️

⚠️ Some required files are missing.

Latest Version: 1.19.0a1

✅ phoonnx/version.py — Version file
✅ README.md — README
❌ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ phoonnx/version.py has valid version block markers

⚖️ License Check

Ensuring our project remains legally compliant. ✅

❌ License violations detected (43 packages) — review required before merging.

Dependency                          License Name                                            License Type         Misc                                    
phoonnx:1.3.3                       Error                                                   Error                                                        

License Type                        Found                                                  
Error                               1

License distribution: 14× MIT License, 7× Apache Software License, 5× MIT, 3× Apache-2.0, 2× BSD-3-Clause, 2× ISC License (ISCL), 1× 3-Clause BSD License, 1× Apache Software License; BSD License, +8 more

Full breakdown — 43 packages

Package	Version	License	URL
`build`	1.5.0	MIT	link
`certifi`	2026.5.20	Mozilla Public License 2.0 (MPL 2.0)	link
`charset-normalizer`	3.4.7	MIT	link
`click`	8.4.1	BSD-3-Clause	link
`combo_lock`	0.3.1	Apache-2.0	link
`dateparser`	1.4.0	BSD License	link
`filelock`	3.29.1	MIT	link
`flatbuffers`	25.12.19	Apache Software License	link
`idna`	3.18	BSD-3-Clause	link
`json-database`	0.10.1	MIT	link
`kthread`	0.2.3	MIT License	link
`langcodes`	3.5.1	MIT License	link
`markdown-it-py`	4.2.0	MIT License	link
`mdurl`	0.1.2	MIT License	link
`memory-tempfile`	2.2.3	MIT License	link
`numpy`	2.4.6	BSD-3-Clause AND 0BSD AND MIT AND Zlib AND CC0-1.0	link
`onnxruntime`	1.26.0	MIT License	link
`ovos-config`	2.1.1	Apache-2.0	link
`ovos-date-parser`	0.7.0a5	Apache Software License	link
`ovos-number-parser`	0.5.1	Apache Software License	link
`ovos-utils`	0.8.5	Apache-2.0	link
`packaging`	26.2	Apache-2.0 OR BSD-2-Clause	link
`pexpect`	4.9.0	ISC License (ISCL)	link
`phoonnx`	1.19.0a1	Apache Software License	link
`protobuf`	7.35.0	3-Clause BSD License	link
`ptyprocess`	0.7.0	ISC License (ISCL)	link
`pyee`	13.0.1	MIT License	link
`Pygments`	2.20.0	BSD-2-Clause	link
`pyproject_hooks`	1.2.0	MIT License	link
`python-dateutil`	2.9.0.post0	Apache Software License; BSD License	link
`pytz`	2026.2	MIT License	link
`PyYAML`	6.0.3	MIT License	link
`quebra-frases`	0.3.7	Apache Software License	link
`regex`	2026.5.9	Apache-2.0 AND CNRI-Python	link
`requests`	2.34.2	Apache Software License	link
`rich`	13.9.4	MIT License	link
`rich-click`	1.9.8	MIT License

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔨 Build Tests

Ensuring the gears are properly lubricated. 💧

✅ All versions pass

Python	Build	Install	Tests
3.10	✅	✅	✅
3.11	✅	✅	✅
3.12	✅	✅	✅
3.13	✅	✅	✅
3.14	✅	✅	✅

From the digital workshop of OpenVoiceOS. 🛠️

github-actions Bot added feature labels Jun 8, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(diacritics): Russian/Ukrainian/Belarusian stress as add_diacritics backends#187

feat(diacritics): Russian/Ukrainian/Belarusian stress as add_diacritics backends#187
JarbasAl wants to merge 1 commit into
devfrom
feat/stress

JarbasAl commented Jun 8, 2026

Uh oh!

coderabbitai Bot commented Jun 8, 2026

Review skipped

Uh oh!

github-actions Bot commented Jun 8, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

JarbasAl commented Jun 8, 2026

Uh oh!

coderabbitai Bot commented Jun 8, 2026

Review skipped

Uh oh!

github-actions Bot commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hello there! I've processed your latest changes. 🌊

🔍 Lint

🔒 Security (pip-audit)

📊 Coverage

📋 Repo Health

⚖️ License Check

🔨 Build Tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Jun 8, 2026 •

edited

Loading