fix(train): make phoonnx_train.export_onnx work on torch>=2.6 by JarbasAl · Pull Request #140 · TigreGotico/phoonnx

JarbasAl · 2026-06-05T02:21:24Z

The piper-derived VITS ONNX exporter (phoonnx_train/export_onnx.py) was broken on modern torch. Three fixes so it can convert any piper/phoonnx checkpoint to ONNX again:

torch.onnx.export(dynamo=False) — VITS has data-dependent control flow that torch 2.x's new dynamo exporter rejects (GuardOnDataDependentSymNode); use the legacy tracer.
force weights_only=False when loading the Lightning checkpoint — torch 2.6 flipped torch.load's default to True, which rejects the pickled hparams (pathlib.PosixPath). Loading a checkpoint to export it is inherently trusted.
export on CPU (model_g.cpu()) so the model and the dummy inputs share a device when CUDA is present.

Verified

Exported HirCoir/piper-sorah-neuronal end-to-end → ONNX with the expected piper inputs [input, input_lengths, scales] and non-silent audio. (No automated test added — it needs a checkpoint fixture + a compiled monotonic_align, which isn't available in CI; the change is a 3-line torch-compat fix to a CLI export tool.)

Split out of the Matcha work as its own small PR; unblocks converting community piper checkpoints to ONNX.

🤖 Generated with Claude Code

The piper-derived VITS exporter broke on modern torch. Three fixes so it can convert any piper/phoonnx checkpoint to ONNX: - torch.onnx.export(dynamo=False) — VITS has data-dependent control flow that the new dynamo exporter rejects; use the legacy tracer. - force weights_only=False when loading the Lightning checkpoint (torch 2.6 flipped the default to True, which rejects pickled hparams like PosixPath). Loading a checkpoint to export it is inherently trusted. - export on CPU (model_g.cpu()) so the model and the dummy inputs share a device when CUDA is present. Verified end-to-end: exported HirCoir/piper-sorah-neuronal -> ONNX with the expected piper inputs [input, input_lengths, scales] and non-silent audio. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

coderabbitai · 2026-06-05T02:21:30Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 14393952-b39e-4a35-ae94-c13dac6e0408

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/export-onnx-torch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-06-05T02:22:09Z

I've completed the automated review of your changes. 📑

I've aggregated the results of the automated checks for this PR below.

📋 Repo Health

I've checked the repo's reflexes (aka build speed). ⚡

⚠️ Some required files are missing.

Latest Version: 1.4.0a1

✅ phoonnx/version.py — Version file
✅ README.md — README
❌ LICENSE — License file
✅ pyproject.toml — pyproject.toml
⚠️ setup.py — setup.py
✅ CHANGELOG.md — Changelog
✅ phoonnx/version.py has valid version block markers

🏷️ Release Preview

The release preview is now complete. 🏁

Current: 1.4.0a1 → Next: 1.4.0a2

Signal	Value
Label	(none)
PR title	`fix(train): make phoonnx_train.export_onnx work on torch>=2.6`
Bump	alpha

⚠️ No conventional commit prefix — alpha-only bump.
Suggested: fix: update the thing or feat: update the thing

🚀 Release Channel Compatibility

Predicted next version: 1.4.0a2

Channel	Status	Note	Current Constraint
Stable	⚪	Not in channel	-
Testing	⚪	Not in channel	-
Alpha	⚪	Not in channel	-

🔍 Lint

I've checked the pulse of your pull request. 💓

❌ ruff: issues found — see job log

🔒 Security (pip-audit)

Scanning the horizon for any zero-day threats. 🌅

✅ No known vulnerabilities found (61 packages scanned).

📊 Coverage

Charting the progress of our testing efforts. 📉

❌ 31.6% total coverage

Files below 80% coverage (37 files)

File	Coverage	Missing lines
`phoonnx/cli.py`	0.0%	98
`phoonnx/thirdparty/kog2p/__init__.py`	0.0%	203
`phoonnx/thirdparty/mantoq/unicode_symbol2label.py`	0.0%	1
`phoonnx/version.py`	0.0%	8
`phoonnx/thirdparty/bw2ipa.py`	7.5%	86
`phoonnx/thirdparty/mantoq/pyarabic/number.py`	7.7%	371
`phoonnx/thirdparty/mantoq/buck/phonetise_buckwalter.py`	10.4%	180
`phoonnx/thirdparty/hangul2ipa.py`	16.6%	372
`phoonnx/phonemizers/en.py`	17.5%	104
`phoonnx/thirdparty/mantoq/pyarabic/trans.py`	18.2%	135
`phoonnx/voice.py`	21.9%	218
`phoonnx/model_manager.py`	22.2%	168
`phoonnx/thirdparty/zh_num.py`	23.1%	83
`phoonnx/phonemizers/mul.py`	23.9%	236
`phoonnx/thirdparty/tashkeel/__init__.py`	23.9%	89
`phoonnx/phonemizers/zh.py`	27.0%	92
`phoonnx/tokenizer.py`	27.2%	225
`phoonnx/phonemizers/ko.py`	30.4%	32
`phoonnx/phonemizers/gl.py`	31.1%	42
`phoonnx/phonemizers/ar.py`	31.2%	44
`phoonnx/thirdparty/mantoq/buck/tokenization.py`	32.5%	27
`phoonnx/thirdparty/phonikud/__init__.py`	35.3%	11
`phoonnx/phonemizers/ja.py`	36.0%	32
`phoonnx/phonemizers/fa.py`	36.4%	14
`phoonnx/phonemizers/pt.py`	38.1%	13
`phoonnx/thirdparty/mantoq/pyarabic/normalize.py`	38.1%	13
`phoonnx/thirdparty/mantoq/pyarabic/araby.py`	39.7%	298
`phoonnx/phonemizers/he.py`	40.0%	12
`phoonnx/phonemizers/vi.py`	40.0%	12
`phoonnx/phonemizers/base.py`	40.8%	71
`phoonnx/config.py`	41.6%	187
`phoonnx/thirdparty/mantoq/pyarabic/stack.py`	45.5%	6
`phoonnx/thirdparty/mantoq/num2words.py`	47.6%	11
`phoonnx/phonemizers/mwl.py`	50.0%	8
`phoonnx/thirdparty/mantoq/__init__.py`	60.0%	10
`phoonnx/thirdparty/mantoq/pyarabic/arabrepr.py`	60.0%	6
`phoonnx/util.py`	79.8%	51

Full report: download the coverage-report artifact.

⚖️ License Check

Ensuring our licenses are OSI-approved. ✅

❌ License violations detected (43 packages) — review required before merging.

Dependency                          License Name                                            License Type         Misc                                    
phoonnx:1.3.3                       Error                                                   Error                                                        

License Type                        Found                                                  
Error                               1

License distribution: 14× MIT License, 7× Apache Software License, 5× MIT, 3× Apache-2.0, 2× BSD-3-Clause, 2× ISC License (ISCL), 1× 3-Clause BSD License, 1× Apache Software License; BSD License, +8 more

Full breakdown — 43 packages

Package	Version	License	URL
`build`	1.5.0	MIT	link
`certifi`	2026.5.20	Mozilla Public License 2.0 (MPL 2.0)	link
`charset-normalizer`	3.4.7	MIT	link
`click`	8.4.1	BSD-3-Clause	link
`combo_lock`	0.3.1	Apache-2.0	link
`dateparser`	1.4.0	BSD License	link
`filelock`	3.29.1	MIT	link
`flatbuffers`	25.12.19	Apache Software License	link
`idna`	3.18	BSD-3-Clause	link
`json-database`	0.10.1	MIT	link
`kthread`	0.2.3	MIT License	link
`langcodes`	3.5.1	MIT License	link
`markdown-it-py`	4.2.0	MIT License	link
`mdurl`	0.1.2	MIT License	link
`memory-tempfile`	2.2.3	MIT License	link
`numpy`	2.4.6	BSD-3-Clause AND 0BSD AND MIT AND Zlib AND CC0-1.0	link
`onnxruntime`	1.26.0	MIT License	link
`ovos-config`	2.1.1	Apache-2.0	link
`ovos-date-parser`	0.7.0a5	Apache Software License	link
`ovos-number-parser`	0.5.1	Apache Software License	link
`ovos-utils`	0.8.5	Apache-2.0	link
`packaging`	26.2	Apache-2.0 OR BSD-2-Clause	link
`pexpect`	4.9.0	ISC License (ISCL)	link
`phoonnx`	1.4.0a1	Apache Software License	link
`protobuf`	7.35.0	3-Clause BSD License	link
`ptyprocess`	0.7.0	ISC License (ISCL)	link
`pyee`	13.0.1	MIT License	link
`Pygments`	2.20.0	BSD-2-Clause	link
`pyproject_hooks`	1.2.0	MIT License	link
`python-dateutil`	2.9.0.post0	Apache Software License; BSD License	link
`pytz`	2026.2	MIT License	link
`PyYAML`	6.0.3	MIT License	link
`quebra-frases`	0.3.7	Apache Software License	link
`regex`	2026.5.9	Apache-2.0 AND CNRI-Python	link
`requests`	2.34.2	Apache Software License	link
`rich`	13.9.4	MIT License	link
`rich-click`	1.9.8	MIT License

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

Policy: Apache 2.0 (universal donor). StrongCopyleft / NetworkCopyleft / WeakCopyleft / Other / Error categories fail. MPL allowed.

🔨 Build Tests

Testing the recipe! Did the build turn out okay? 👨‍🍳

✅ All versions pass

Python	Build	Install	Tests
3.10	✅	✅	✅
3.11	✅	✅	✅
3.12	✅	✅	✅
3.13	✅	✅	✅
3.14	✅	✅	✅

Automating the boring stuff so you don't have to! 🚀

github-actions Bot added fix and removed fix labels Jun 5, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(train): make phoonnx_train.export_onnx work on torch>=2.6#140

fix(train): make phoonnx_train.export_onnx work on torch>=2.6#140
JarbasAl wants to merge 1 commit into
devfrom
fix/export-onnx-torch

JarbasAl commented Jun 5, 2026

Uh oh!

coderabbitai Bot commented Jun 5, 2026

Review skipped

Uh oh!

github-actions Bot commented Jun 5, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

JarbasAl commented Jun 5, 2026

Verified

Uh oh!

coderabbitai Bot commented Jun 5, 2026

Review skipped

Uh oh!

github-actions Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I've completed the automated review of your changes. 📑

📋 Repo Health

🏷️ Release Preview

🔍 Lint

🔒 Security (pip-audit)

📊 Coverage

⚖️ License Check

🔨 Build Tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Jun 5, 2026 •

edited

Loading